Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

fix: Convert js files from es6 to es5 #589

Merged
merged 7 commits into from
Nov 25, 2019
Merged

Conversation

driskull
Copy link
Member

Related Issue: #588

Summary

Make these files run in es5

@driskull driskull added this to the Eberhardt milestone Nov 22, 2019
@driskull driskull requested a review from a team as a code owner November 22, 2019 22:42
@driskull driskull self-assigned this Nov 22, 2019
@driskull driskull requested a review from jcfranco November 25, 2019 21:55
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


const clientWebSocket = new window.WebSocket(getSocketUrl(window.location), ["xmpp"]);

clientWebSocket.addEventListener("message", (message) => {
clientWebSocket.addEventListener("message", function(message) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: can you restore the newline here?

@driskull driskull changed the title es5 js files fix: Convert js files from es6 to es5 Nov 25, 2019
@driskull driskull merged commit 789554f into master Nov 25, 2019
@driskull driskull deleted the dris0000/es5-js-files branch November 25, 2019 23:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants