Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

fix(block): hide collapse icon when a control is provided in Edge #582

Merged

Conversation

jcfranco
Copy link
Member

Related Issue: #540

Summary

Changes control/content-checking logic to query the DOM instead of checking the slot property directly (always null in Edge).

@jcfranco jcfranco added the bug Something isn't working label Nov 22, 2019
@jcfranco jcfranco added this to the Eberhardt milestone Nov 22, 2019
@jcfranco jcfranco requested a review from a team as a code owner November 22, 2019 01:01
@jcfranco jcfranco self-assigned this Nov 22, 2019
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🌮

@jcfranco jcfranco merged commit 6d9f0e3 into master Nov 22, 2019
@jcfranco jcfranco deleted the jcfranco/540-fix-section-collapse-icon-not-hiding-in-edge branch November 22, 2019 21:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants