This repository has been archived by the owner on Jun 29, 2023. It is now read-only.
shift deselect for lists 551 #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driskull
suggested changes
Nov 21, 2019
driskull
approved these changes
Nov 25, 2019
jcfranco
suggested changes
Nov 26, 2019
| const domList: HTMLCalcitePickListElement | HTMLCalciteValueListElement = document.querySelector( | ||
| `calcite-${type}-list` | ||
| ); | ||
| return domList.getSelectedItems().then((result) => { |
There was a problem hiding this comment.
Nitpick: can you use await to reduce promise nesting?
jcfranco
reviewed
Dec 3, 2019
There was a problem hiding this comment.
I really like the idea of marking truly optional props (prop: <type> | undefined) across all components. Ionic components do this already (example). Should the following props also be updated?
pick-list-item | value-list-item
textLabelrequired?iconoptional?
It is worth noting that the union type fix is a side-effect and should not be used as a solution for union type errors going forward.
jcfranco
approved these changes
Dec 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #551
Summary
selectSiblingsselectSiblingsfor deselect and added a flag for adding/removing since most of hte logic is shared for both cases. Didn't rename, but let me know if you have a new suggested function name.