This repository has been archived by the owner on Jun 29, 2023. It is now read-only.
feat: Add property & event for toggling the opening or closing of the TipManager #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add container class for div - Add new event and deprecate old event - Update tests - Fix shadowed var
driskull
added
enhancement
driskull
commented
Nov 8, 2019
| @@ -132,9 +143,15 @@ export class CalciteTipManager { | |||
|
|
|||
| /** | |||
| * Emitted when the component has been closed. | |||
| * @deprecated | |||
| @@ -551,7 +551,7 @@ <h3 class="heading" slot="header-content">WE CARE A LOT</h3> | |||
| var tipManagerButton = document.getElementById("tip-manager-button"); | |||
| var tipManager = document.getElementById("tip-manager"); | |||
| tipManagerButton.addEventListener("click", function(){ | |||
| tipManager.hasAttribute("hidden") ? tipManager.removeAttribute("hidden") : tipManager.setAttribute("hidden", ""); | |||
| tipManager.closed = !tipManager.closed; | |||
pr3tori4n
reviewed
Nov 11, 2019
pr3tori4n
approved these changes
Nov 11, 2019
driskull
changed the title
driskull
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #530
Summary
closedproperty to TipManager