Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

feat(pick-list-group, pick-list-item, tip-group, tip-manager, value-list-item): add replacement text props #1060

Merged
merged 6 commits into from
Oct 2, 2020

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Aug 26, 2020

Related Issue: N/A

Summary

Deprecates text<Name> props in favor of <name> for consistency.

The only remaining one is textFilterPlaceholder. Not sure if this should be filterPlaceholder or intlFilterPlaceholder instead. Went with filterPlaceholder.

@jcfranco jcfranco added enhancement New feature request for an existing component chore A minor task, usually housekeeping labels Aug 26, 2020
@jcfranco jcfranco added this to the Peppermint Butler milestone Aug 26, 2020
@jcfranco jcfranco self-assigned this Aug 26, 2020
@jcfranco jcfranco marked this pull request as ready for review October 2, 2020 17:05
@jcfranco jcfranco requested a review from a team as a code owner October 2, 2020 17:05
@jcfranco jcfranco requested a review from driskull October 2, 2020 17:06
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Collaborator

@eriklharper eriklharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jcfranco jcfranco merged commit 5866926 into master Oct 2, 2020
@jcfranco jcfranco deleted the jcfranco/deprecate-text-prefixed-props branch October 2, 2020 17:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
chore A minor task, usually housekeeping enhancement New feature request for an existing component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants