Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

feat(value-list): allow dragging items between lists #1059

Merged
merged 5 commits into from
Aug 25, 2020
Merged

feat(value-list): allow dragging items between lists #1059

merged 5 commits into from
Aug 25, 2020

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Aug 25, 2020 •
edited
Loading

Related Issue: #1056

Summary

Adds group prop to value-list to allow drag and drop items across lists with the same group (requires dragEnabled === true).

Notes

  • This also adds a e2e utility to help test DnD interactions and unskips previous DnD tests. 🛠️
  • I'll cherry-pick this over to calcite-components when merged. 😄

Questions

  • Since dragging between lists requires dragEnabled to be true, would it be better to rename the prop to dragGroup or something similar to indicate that they are linked?
  • I had not considered using the keyboard to move items across lists, is this something we should support? cc @asangma

@jcfranco jcfranco added the enhancement New feature request for an existing component label Aug 25, 2020
@jcfranco jcfranco added this to the Peppermint Butler milestone Aug 25, 2020
@jcfranco jcfranco requested review from driskull and asangma August 25, 2020 15:57
@jcfranco jcfranco requested a review from a team as a code owner August 25, 2020 15:57
@jcfranco jcfranco self-assigned this Aug 25, 2020
driskull
driskull approved these changes Aug 25, 2020
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👏

@jcfranco jcfranco merged commit 1c35a0d into master Aug 25, 2020
@jcfranco jcfranco deleted the jcfranco/1056-allow-dragging-items-between-value-lists branch August 25, 2020 17:31
@jcfranco jcfranco mentioned this pull request Aug 25, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@driskull driskull driskull approved these changes

@asangma asangma Awaiting requested review from asangma

Assignees

@jcfranco jcfranco

Labels
enhancement New feature request for an existing component
Projects
None yet
Milestone
Peppermint Butler
Development

Successfully merging this pull request may close these issues.
2 participants
@jcfranco @driskull