Skip to content
This repository has been archived by the owner on Aug 22, 2023. It is now read-only.

Turn stake table impl generic over key-value types #76

Closed
alxiong opened this issue Jul 5, 2023 · 0 comments
Closed

Turn stake table impl generic over key-value types #76

alxiong opened this issue Jul 5, 2023 · 0 comments
Assignees

Comments

@alxiong
Copy link
Collaborator

alxiong commented Jul 5, 2023

See #66 (comment)


update: after some local attempts and discussion with @mrain, we realize that generic over V would cause unnecessary code complexity.
(particularly, u256_to_field() and sample() that internally sample a U512 first, and mod into U256 for negligible non-uniformity)
given this stake table is only used in hotshot, we gonna stick with concrete U256 type for now, and only generic over key type K.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant