Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate existing header fields once HotShot supports validated state #968

Closed
jbearer opened this issue Jan 10, 2024 · 1 comment · Fixed by #2089
Closed

Validate existing header fields once HotShot supports validated state #968

jbearer opened this issue Jan 10, 2024 · 1 comment · Fixed by #2089

Comments

@jbearer
Copy link
Member

jbearer commented Jan 10, 2024

  • height increases by 1
  • timestamp is within some delta of the current time and not decreasing
  • L1 head is within some delta of the current L1 head and not decreasing
  • L1 finalized is accurate, within some delta of the current L1 head, not in the future, and not decreasing
@tbro
Copy link
Contributor

tbro commented Jul 10, 2024

from zulip:

I think we are missing these checks:

  • timestamp is within some delta of the current time
  • L1 head is within some delta of the current L1 head
  • L1 finalized is accurate, within some delta of the current L1 head, not in the future

I think to properly enforce these we should add some parameters to the chain config:

  • max_time_drift
  • max_l1_head_drift
  • max_l1_finalized_drift

Adding these would be a breaking change, so let's circle back to this after the versioning PR is merged, and we can incorporate these checks into 0.3 along with the marketplace

@tbro tbro self-assigned this Oct 1, 2024
@tbro tbro mentioned this issue Oct 1, 2024
@tbro tbro closed this as completed in #2089 Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants