Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review and refactor state validation logic #2090

Open
tbro opened this issue Oct 1, 2024 · 1 comment · May be fixed by #2170
Open

Review and refactor state validation logic #2090

tbro opened this issue Oct 1, 2024 · 1 comment · May be fixed by #2170
Assignees
@tbro
Labels
maintenance

Comments

@tbro
Copy link
Contributor

tbro commented Oct 1, 2024 •
edited
Loading

Some quick fixes to validate_and_apply_header in #2089 have left it in a disorganized state. We now have some async calls which need to be dealt with, but the primary validation function is synchronous. We should think about the best way to organize this. Ideally each validation step would be represented by a variant of ProposalValidationError and in validate_and_apply_header we would log those as we currently do with validate_proposal.
@tbro tbro self-assigned this Oct 1, 2024
@tbro tbro mentioned this issue Oct 1, 2024
Merged
@tbro
Copy link
Contributor Author

tbro commented Oct 2, 2024

Possibly should be done in tandem w/ #2100

@tbro tbro linked a pull request Oct 11, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tbro tbro

Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replica Validation Refactor EspressoSystems/espresso-sequencer
2 participants
@sveitser @tbro