Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I05: Inability to reduce stateHistoryRetentionPeriod #2076

Open
alysiahuggins opened this issue Sep 26, 2024 · 1 comment
Open

I05: Inability to reduce stateHistoryRetentionPeriod #2076

alysiahuggins opened this issue Sep 26, 2024 · 1 comment

Comments

@alysiahuggins
Copy link
Contributor

Affected Code: LightClient.sol (line 441)

Summary: The function setstateHistoryRetentionPeriod wrongly when
reducing the retention period, which can lock in a large value if set
by mistake.

Suggestion: Instead of reverting when the retention period decreases,
updateStateHistory could be called with the last finalized state to delete
the newly outdated states.

Comments: This was intentional for this version of the escape hatch but will address later.

@alysiahuggins
Copy link
Contributor Author

This will not be addressed right now however we have created an issue to set a max state history retention period allowed #2114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant