Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option<Epoch> change #3967

Open
pls148 opened this issue Dec 13, 2024 · 0 comments
Open

Option<Epoch> change #3967

pls148 opened this issue Dec 13, 2024 · 0 comments
Assignees

Comments

@pls148
Copy link
Contributor

pls148 commented Dec 13, 2024

In several places, we pass epoch=0 and then rely on things like version >= Epochs::VERSION to decide on whether or not we use it.

Version itself is not always available, e.g. when calculating commitments. To resolve this, make places which are incapable of deciding whether or not epochs are enabled take Option instead of Epoch. Work backwards until ambiguity is resolved.

@pls148 pls148 self-assigned this Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant