Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom health check properties #33

Open
jswiesner opened this issue Jan 8, 2018 · 1 comment
Open

Add custom health check properties #33

jswiesner opened this issue Jan 8, 2018 · 1 comment

Comments

@jswiesner
Copy link
Contributor

If Para uses the DropWizard health check, we can open up the opportunity to implement custom health check properties that layer in on top of the existing ones that Para uses. Para would register a root HealthCheckRegistry, and then we can expose a way for external code to add new properties. This would allow a custom DAO plugin, for example, to implement more sophisticated health check measures if desired.

@albogdano
Copy link
Member

Sounds good. The easiest of way to do this is to load HealthCheckerAddon implementations through ServiceLoader and execute them one by one after the standard checks in HealthUtils. The interface could be:

public interface HealthCheckerAddon {
   public boolean performAdditionalHealthCheck(); 
}

And if one of the loaded external checks returns false the system would become unhealthy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants