-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default image or default visibility #70
Comments
You've got a point. If we use notification categories (mail, social, etc) we can set a custom icon for that category. The default icon isn't really that pretty so we probably need a new one too |
Would you rather use icon-theme icons or like for the sounds, go with a custom image path? For these one, I'm more for sticking with the theme. |
I'd go with the icon-theme |
I find the default image confusing too -- when an application specified no image, just showing a generic "photo" image makes little sense. It gives an impression that the notification is somehow related to a photo application. I think if an application specified "no icon", it's best to respect that rather than try and show a fallback -- I can't think of any icon that would add clarity to all notifications without icons. |
"when-available" should now be the default :) |
Looking good, thanks! |
The default behaviour states that a notification always comes with a visible image, and it resorts at last to a broken_image icon when it was not possible to gather an image, app icon or desktop icon from the provided info.
The implementation works flawlessly for what I could try, but it also makes the noti history look quite strange this way, especially if one has multiple scripts sending messages to the user without icons or images.
It kinda feel broken.
Wouldn't it be better to change the default visibility to "when-available" or change the fallback image to something more generic and less broken-looking?
The text was updated successfully, but these errors were encountered: