macro ref_cte_name(node) is not working properly

[adrian-damaschin]

This macro should return a CTE name for our source from concatenating package_name + node_name + node_version
https://github.com/EqualExperts/dbt-unit-testing/blob/master/macros/sql_builders.sql#L39

However this statement:
https://github.com/EqualExperts/dbt-unit-testing/blob/master/macros/sql_builders.sql#L45
returns True even if my node doesn't have a version key in the JSON. This way it means the final CTE name would be:

package_name__node_name__

which I am guessing is not the desired outcome

[lkell]

I am having the same issue, specifically for a dbt seed. I haven't looked into the source code too much so I don't know if this is a good general fix, but I found that changing https://github.com/EqualExperts/dbt-unit-testing/blob/master/macros/sql_builders.sql#L45C32-L45C32 to

{% if node.version is not none and node.version is defined %}

resolved the issue for me.

[psousa50]

Hi all,

We've just released version v0.3.3, which should address this issue.

Please give it a try, and thank you very much for your feedback.

[adrian-damaschin]

@psousa50
Yes, this solves the empty version issue. Thank you
However the framework is still not usable for us because of :
#169