Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to default max_trials inf and pool-size 1 #644

Closed
bouthilx opened this issue Aug 27, 2021 · 0 comments · Fixed by #659
Closed

Revert to default max_trials inf and pool-size 1 #644

bouthilx opened this issue Aug 27, 2021 · 0 comments · Fixed by #659
Labels
enhancement Improves a feature or non-functional aspects (e.g., optimization, prettify, technical debt)
Milestone

Comments

@bouthilx
Copy link
Member

bouthilx commented Aug 27, 2021

The new default behavior is confusing for users. It is also difficult to determine a good default max_trials, so having not enough or to many trials sampled by default at the start of HPO can be annoying for many users. Using inf by default and iterating with pool-size may be the best alternative.

Now that we have a support for n-workers, the argument pool-size we previously deprecated could actually make sense. By default, pool-size should be equal to number of workers. We have n-workers set to 1 by default, so by default we would be back to previous behavior; sampling 1 trial at a time, until max_trials.

@mgermain

@bouthilx bouthilx added the enhancement Improves a feature or non-functional aspects (e.g., optimization, prettify, technical debt) label Aug 27, 2021
@bouthilx bouthilx added this to the v0.1.17 milestone Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves a feature or non-functional aspects (e.g., optimization, prettify, technical debt)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant