Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigFloat support #346

Open
wsmoses opened this issue May 31, 2022 · 4 comments
Open

BigFloat support #346

wsmoses opened this issue May 31, 2022 · 4 comments

Comments

@wsmoses
Copy link
Member

wsmoses commented May 31, 2022

see LeilaGhaffari/enzyme-proto#2

cc @LeilaGhaffari @jedbrown

@wsmoses
Copy link
Member Author

wsmoses commented May 31, 2022

@LeilaGhaffari per your other Github issue, one what timeline would support for this be needed?

To do some expectation setting / figure out prioritization, enabling support for custom base types (like this) are on the roadmap, but do have a nontrivial amount of infrastructure that would be required first so it's not an instantly solvable thing. For BigFloat in particular, we may be able to just use custom derivative rules for the various operators and that may be sufficient -- but that would also be ideal to have #177 land first so it would be easier to write all of those.

@jedbrown
Copy link

Honestly, I don't think it's a big deal. The BigFloat here is for reference values to measure accuracy of the f32/f64 computation. But we can compute reference values using Zygote or with "by hand" differentiation.

@jedbrown
Copy link

Better to put resources into #177.

@LeilaGhaffari
Copy link

Thanks for creating this issue. I went ahead and closed #676.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants