-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make instance
and make switch
should optionally source ~/.bashrc
#89
Comments
I also just noticed that completion is only partial in subshells. I can type |
You just need to eval the completion code the same way as is in your .bashrc, so I think it will be solved by adding
|
Oh, I see. Completeion isn't configured within d.ry, it's configured within my shell, and hence not (currently) in the subshell. |
I just pushed ffda844, but it doesn't work yet. I'm struggling with the syntax to make the subshell source the file. |
open a pull request and i will review. |
Discussed in #87
Originally posted by mcmikemn July 29, 2023
When you
make instance
, d.rymcg.tech creates a sub-shell for the new instance. Can that subshell retain or copy the environment from the main shell? For example, I have aliases set up in .bashrc in my main shell, but they're not available in the sub-shell.Because we cannot control what a user has in their ~/.bashrc it should not be the default behaviour to source it in the
make instance
subshell, however it might be nice to extend the environment by sourcing a select file by configuration.A root environment variable like
MAKE_INSTANCE_SOURCE_RCFILE=
would be blank (or/dev/null
) by default, but if you set this variable to a file path, it should source that file it before the other variables in the make instance/switch script, thus extending the user's environment.The text was updated successfully, but these errors were encountered: