Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various issues with shaders #6

Open
SecretlyJealous opened this issue Sep 10, 2019 · 12 comments
Open

Various issues with shaders #6

SecretlyJealous opened this issue Sep 10, 2019 · 12 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@SecretlyJealous
Copy link

SecretlyJealous commented Sep 10, 2019

I'm using the SEUS PTGI E9 ray tracing shader pack but the colors don't work when I use that pack:

image

Without the shaderpack it works:
image

I'm guessing this must be an issue with every shaderpack? I want to be able to use the shaderpack though while also using WorldEdit CUI. Just not sure if this is something that the shaderpack needs to fix or if it's something WorldEdit CUI needs to account for.

@mikroskeem
Copy link
Collaborator

Can you also try other shaderpacks? I think it's very likely because how WECUI is drawing the lines, but I would like to know if this indeed happens with all of them.

@mikroskeem mikroskeem added bug Something isn't working help wanted Extra attention is needed labels Sep 10, 2019
@SecretlyJealous
Copy link
Author

Yeah it seems to affect any shaderpack that I use

@mikroskeem
Copy link
Collaborator

Can you also reproduce this with 1.12.2 WorldEditCUI? Just to rule out that my fork isn't the culprit.

@enveeed
Copy link

enveeed commented Nov 12, 2019

I believe WE CUI and shaders never played nice, ever. I've used this mod since when LiteLoader was new and shaders weren't in optifine and while it's usable the colors never worked right, on any version I've personally used.
Maybe you can somehow incorporate the line drawing into fabrics / optifines rendering pipeline instead of using OpenGL directly? I'm not too big on graphics programming, so no idea if that would help, but it's an idea.

@mikroskeem
Copy link
Collaborator

mikroskeem commented Nov 12, 2019 via email

@enveeed
Copy link

enveeed commented Nov 12, 2019 via email

@RuofengX
Copy link

RuofengX commented Jun 7, 2020

I have the similar problem. It works in 1.14.4, but when I moving to 1.15.2, the frame DONT show up in any shaderpack(BSL and Sildurs).
I use fabric and here is my problem mod list:
image
The same mods I used in 1.14.4 including CUI1.14.4_3 really WORK.

@zml2008
Copy link
Collaborator

zml2008 commented Jan 3, 2021

WorldEdit CUI test build with semi-working Sildur's shaders on OptiFine

I've made some progress on this issue. There are still issues with drawing selections over skies and waters which I hope to make progress on, but once my work is tidied up even what I have so far will be an improvement.

@mikroskeem mikroskeem changed the title Colors not showing when using shaders Various issues with shaders Jan 15, 2021
@arturek1666
Copy link

Thanks works like a charms with the one I use :)
image

@VozDeOuro
Copy link

i'm using forge and seus shaders pack
but my lines dot get colors keeps all black
anyone know a fix for it ?
image

@zml2008
Copy link
Collaborator

zml2008 commented Jun 9, 2021

WorldEditCUI is not available for Forge (at least not in a form anyone here supports or can recommend)

@kencinder
Copy link

kencinder commented Feb 12, 2022

I didn't feel opening a new issue for this made sense, given it's already labelled and ongoing.

Not having any issues with actual worldedit selections, they display correctly as far as I can tell. But Griefdefender claim visualizations and WECUI's Chunk Borders are problematic.

GriefDefender claim visualizations are pretty opaque.

2022-02-12_12 18 26

Chunk Borders turned on via the WECUI key make the entire screen opaque, not just the borders

2022-02-12_12 19 02

I'm using the following mods for Fabric 0.13.1 on 1.18.1 (Left out mods that have no relevance to rendering at all, have seen the issue on a test setup without them)

Fabric API 0.46.4
Indium 1.0.2a2
Iris 1.2.0
Sodium 0.4.0a6
Starlight 1.0.0

With the shader pack Complementary Shaders 4.3.3

I have seen the same results with a few other shaders such as BSL and Seus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

8 participants