Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Change python3 to python #7

Closed
mxschmitt opened this issue Feb 27, 2024 · 4 comments · Fixed by #8
Closed

[BUG] Change python3 to python #7

mxschmitt opened this issue Feb 27, 2024 · 4 comments · Fixed by #8

Comments

@mxschmitt
Copy link

If you install Python on a Windows machine, it usually is only available as python and not as python3. This will then e.g. break the following:

We can probably expect nowadays machines have Python3 as python. Would you be up for a contribution to change python3 -> python?

Happy for more thoughts on this, thanks!

@ola-rozenfeld
Copy link
Contributor

Hmm, we have Chromium builds on Windows, and what worked was running both scripts with cmd, e.g.:

cmd.exe /c "python3 reclient-configs\configure_reclient.py --src_dir=%SRC_PATH%"

So Windows can run python3, it just needs some convincing :-)

I'm a wary that the change might backfire with existing users, e.g. Brave. To make it backward compatible we'd probably need to clone both scripts and have a python version alongside a python3 version, which is just not quite worth it, imo.

@mxschmitt
Copy link
Author

mxschmitt commented Feb 29, 2024

hm weird! So when I installed Python officially there was only python and no python3 in my PATH. Sounds like python/cpython#99185.

TL;DR: python3 will target the WindowsStore Python while python will target the actual python.exe.

I have a workaround for now, so happy to close, just confusing and I thought python is what tools use nowadays.

What convention does Chromium use upstream? Looks like python3.

@ola-rozenfeld
Copy link
Contributor

What convention does Chromium use upstream? Looks like python3.

AFAIK, Chromium migrated to python3 everywhere and now relies on the Python version to be at least 3.8.

However: I just realized that I think I can fix your problem with just this: #8
Can you try this out, please? Thank you!

@mxschmitt
Copy link
Author

I can confirm that this works for us. Appreciate!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants