Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ranged Scales #22

Open
EmmanuelDodoo opened this issue Sep 17, 2024 · 1 comment · Fixed by #28
Open

Ranged Scales #22

EmmanuelDodoo opened this issue Sep 17, 2024 · 1 comment · Fixed by #28
Labels
feature add new feature

Comments

@EmmanuelDodoo
Copy link
Owner

The plan for Scale is to have it support both a list of points and a range of points. The current implementation only supports the list variant. Implementation of ranged scales is currently halted, awaiting std::iter::Step coming to stable rust. Here's the PR for it.

Once the trait comes to stable, it can be implemented for Data::Integer and Data::Number. Not quite sure if it'll be possible for Data::Float
@EmmanuelDodoo EmmanuelDodoo added the feature add new feature label Sep 17, 2024
@EmmanuelDodoo EmmanuelDodoo linked a pull request Oct 8, 2024 that will close this issue
Feature/numeric scale #28
Merged
@EmmanuelDodoo
Copy link
Owner Author

I've implemented a basic version of this. Not fully ranged but not categorical like before

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature add new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/numeric scale EmmanuelDodoo/modav_core
1 participant
@EmmanuelDodoo