Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduction not above the fold #18

Closed
metbril opened this issue Dec 1, 2019 · 16 comments
Closed

Introduction not above the fold #18

metbril opened this issue Dec 1, 2019 · 16 comments

Comments

@metbril
Copy link
Contributor

metbril commented Dec 1, 2019

Using an older MacBook Air with screen resolution, the Introduction page, including the social icons, does not get fitted into the first full page. Part of my introduction text is cut off, and the social icons are not on the first screen. I have to scroll to see them.

The resolution is 1440x900 pixels.

There is sufficient room above my portrait to fit it.

@EmielH
Copy link
Owner

EmielH commented Dec 5, 2019

Thanks for bringing this to my attention! I will look into this as soon as I have a bit of spare time.

@msuiche
Copy link

msuiche commented Dec 15, 2019

Agreed. This is what I see
image

Here is my resolution:
image

@EmielH
Copy link
Owner

EmielH commented Dec 22, 2019

@metbril @msuiche Could you tell me the browsers that you're using? I'm having a hard time reproducing this behaviour.

@metbril
Copy link
Contributor Author

metbril commented Dec 22, 2019

Mostly Firefox (Mac) but I think the same goes for Brave and Safari for Mac. I will check when I have access to a computer.

@Sidra-Kazmi
Copy link

Sidra-Kazmi commented Aug 14, 2020

Update: This is a problem only on the Windows machines. I was having the issue on my Windows 10 machine, I switched to MAC using Safari and it rendered just fine.


Hello, I am seeing the distorted page layout as well. I tried this on 3 browsers. Chrome, Opera and Edge. I have tried this on Mac / Safari and Chrome as well and its the same issue. The Zoom resolution on the browsers is set to 125% and my display resolution is
image.

this is what I see as well.

image

@EmielH
Copy link
Owner

EmielH commented Aug 18, 2020

Thanks for letting me know! I will investigate again.

@metalolf
Copy link

Same here!

@vale-tech
Copy link

vale-tech commented Nov 17, 2020

Yeah same problem for me as well. The sample site at https://themes.gohugo.io/theme/hallo-hugo/ looks fine though which is a bit strange.

Update: I switched over to hugo-extended and it now looks fine. YMMV

@EmielH
Copy link
Owner

EmielH commented Nov 17, 2020

These are interesting clues. I will test with the regular version of Hugo. Does any of you have your site in a public repo so I can check that too?

@metbril
Copy link
Contributor Author

metbril commented Nov 17, 2020

I haven't checked it for a while but this is my repo:

https://github.com/metbril/hallo-robert

@vale-tech
Copy link

https://github.com/vale-tech/vtrujillo-website

Your theme was exactly what I was looking for. Thanks!

@EmielH
Copy link
Owner

EmielH commented Nov 17, 2020

Thanks to your tips I think I finally found the cause of this issue. It looks like some styles were missing from the pre-generated CSS files for Hugo Basic. I just committed a patch. Could you check if this solves your problem?

@vale-tech
Copy link

Yes sir, working now for me with normal Hugo and Win10. Cheers!

@EmielH
Copy link
Owner

EmielH commented Nov 17, 2020

Glad to hear it! I'll close this issue and release a new version.

@EmielH EmielH closed this as completed Nov 17, 2020
@metbril
Copy link
Contributor Author

metbril commented Nov 18, 2020

It's not yet fixed for me:

afbeelding

@EmielH
Copy link
Owner

EmielH commented Nov 18, 2020

Ah! That's actually a different issue (probably the one you tried to report in the first place). My apologies for misunderstanding. I was going by the screenshots earlier in this issue. Currently, the spacing between the different parts of the site (e.g. the space above the photo and the space between the headers) is fixed. I created a new issue (#22) to try and improve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants