Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Don't name everything after spirv. #128

Closed
lachlansneff opened this issue Oct 24, 2020 · 2 comments
Closed

Suggestion: Don't name everything after spirv. #128

lachlansneff opened this issue Oct 24, 2020 · 2 comments
Labels
mcp: proposed A major change to the compiler, that hasn't yet been approved.

Comments

@lachlansneff
Copy link

Proposal

I'm suggesting that the rust-gpu project doesn't name all the attributes and crates after "spirv". There are many gpu languages, and restricting this project to just spirv so early one might not be a good idea. And if it expands later to other languages, but the attributes and crates are still called spirv, it could pretty easily get confusing.

Instead, name things shader or gpu. e.g. #[shader(...)] and use std_shader::....

@lachlansneff lachlansneff added the mcp: proposed A major change to the compiler, that hasn't yet been approved. label Oct 24, 2020
@repi
Copy link
Contributor

repi commented Oct 24, 2020

Agreed! Which is why we also overall called the project/repo "Rust GPU" and have https://shader.rs :)
Do hope that the current spirv-std will evolve to a std-shader (or std-gpu or similar).

There are some SPIRV-specific intrinsics and types also though on the lower layers, but now when we can do #[cfg(target_arch = "spirv")] that will be very helpful in our own crates as well as others crates to compile in SPIRV-specifics but building general crates that can be compile for multiple targets, including CPU.

@XAMPPRocky
Copy link
Member

We discussed at the meeting, and the consensus was that we are in favour of changing the name, but want to wait until project is further along before renaming anything. So I'm going to close this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mcp: proposed A major change to the compiler, that hasn't yet been approved.
Projects
None yet
Development

No branches or pull requests

3 participants