From d29dfc7083da5defd84705ee297bb4098e1468e8 Mon Sep 17 00:00:00 2001 From: Finn Bacall Date: Mon, 7 Nov 2022 15:31:36 +0000 Subject: [PATCH] Fixed missing translation for `resource_type` hint. Enabled option to raise exceptions when translation missing in dev/test Removed whitelisted web console IP --- app/views/materials/_form.html.erb | 4 ++-- config/environments/development.rb | 5 +---- config/environments/test.rb | 2 +- config/locales/en.yml | 2 +- 4 files changed, 5 insertions(+), 8 deletions(-) diff --git a/app/views/materials/_form.html.erb b/app/views/materials/_form.html.erb index 50fe0e227..a16f30e36 100644 --- a/app/views/materials/_form.html.erb +++ b/app/views/materials/_form.html.erb @@ -92,8 +92,8 @@ <%= f.input :date_published, as: :date_picker, field_lock: true, input_html: { title: t('materials.hints.date_published') } %> - <%= f.multi_input :resource_type, label: 'Resource types', errors: @material.errors[:material_types], - title: t('events.hints.type') %> + <%= f.multi_input :resource_type, label: 'Resource types', errors: @material.errors[:resource_type], + title: t('materials.hints.resource_type') %> <% if !TeSS::Config.feature['disabled'].include? 'other_types' %> diff --git a/config/environments/development.rb b/config/environments/development.rb index 7ac1e5a3a..1e4fda5f0 100644 --- a/config/environments/development.rb +++ b/config/environments/development.rb @@ -60,9 +60,6 @@ protocol: URI.parse(TeSS::Config.base_url).scheme } - # console whitelisted ip addresses - config.web_console.whitelisted_ips = '1.120.119.251' - # Print deprecation notices to the Rails logger. config.active_support.deprecation = :log @@ -81,7 +78,7 @@ config.assets.quiet = true # Raises error for missing translations - # config.action_view.raise_on_missing_translations = true + config.i18n.raise_on_missing_translations = true # Use an evented file watcher to asynchronously detect changes in source code, # routes, locales, etc. This feature depends on the listen gem. diff --git a/config/environments/test.rb b/config/environments/test.rb index 77b4c0033..5669608e0 100644 --- a/config/environments/test.rb +++ b/config/environments/test.rb @@ -43,7 +43,7 @@ config.active_support.deprecation = :stderr # Raises error for missing translations - # config.action_view.raise_on_missing_translations = true + config.i18n.raise_on_missing_translations = true config.action_mailer.default_url_options = { host: 'localhost', port: 3000 } config.action_mailer.asset_host = TeSS::Config.base_url diff --git a/config/locales/en.yml b/config/locales/en.yml index f2a084149..d9da2ee9a 100644 --- a/config/locales/en.yml +++ b/config/locales/en.yml @@ -307,7 +307,7 @@ en: targets: 'Indicate the type of audience intended to use your training material.' time: 'What is the estimated time it takes to work through this resource in hours?' title: 'Add a title for your training material.' - type: 'Select the type of resource that best matches the training material. ' + resource_type: 'Select the type of resource that best matches the training material. ' url: 'Preferred URL to direct people to your training material landing page.' version: 'Indicate the current version of the training material.' profile: