Skip to content

Commit

Permalink
Revert "Try not caching journey test dependencies"
Browse files Browse the repository at this point in the history
This reverts commit bf2abdb, the
supporting change in GitoxideLabs#1725 that refrained from caching build
artifacts from the `test-journey` job, since that no longer needs
to be avoided now that `git-daemon` journey tests aren't run on CI.

In 9566488 (GitoxideLabs#1634), journey tests that use `git-daemon` were
disabled on CI. GitoxideLabs#1725 tried reenabling them (65788e8) and fixing
them by no longer caching build artifacts with the `rust-cache`
action in the `test-journey` job (bf2abdb). This worked at the
time, but the exact reason it worked or how reliable it would be
were unknown. It stopped working shortly thereafter in 25b8480
(GitoxideLabs#1726), and those journey tests were re-disabled on CI in d1d3f7c,
which reverted 65788e8. However, bf2abdb was not reverted at that
time.

(The change in d1d3f7c from GitoxideLabs#1726, taken together with this
commit, effectively constitute a revert of PR GitoxideLabs#1725.)
  • Loading branch information
EliahKagan committed Dec 18, 2024
1 parent 69ee6a3 commit d9415c5
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,7 @@ jobs:
steps:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@stable
- uses: Swatinem/rust-cache@v2
- uses: extractions/setup-just@v2
- name: Run journey tests
run: just ci-journey-tests
Expand Down

0 comments on commit d9415c5

Please sign in to comment.