python plugin: topic 'shutdown' is not a known notification topic

[SimonVrouwe]

Issue and Steps to Reproduce

Experimenting with a python plugin to catch the "shutdown" notification for cleanup, but plugin is never notified and CL has following in log:

plugin-thread_plugin.py: topic 'shutdown' is not a known notification topic

The plugin uses from pyln.client import Plugin (pyln-client 0.10.1) and subscribes to "shutdown" using the decorator @plugin.subscribe("shutdown")

getinfo output

edit "version": "v0.10.1" `"version": "v0.10.1-123-g84957be"

[SimonVrouwe]

After some investigation, changing plugin_shutdown to shutdown in this line solves it.

lightning/lightningd/notification.c

Line 558 in 84957be

REGISTER_NOTIFICATION(plugin_shutdown, NULL);

EDIT: Ok I just see this code was all just added 6 days ago in #4754 , right in time!
Please ignore below.

What I don't understand is why build-in plugins don't complain with the same error, i.e. as build-in plugins seem to automatically subscribe to the "shutdown" notification. For example the autoclean plugins getmanifest result looks like:

{"jsonrpc":"2.0","id":0,"result":{"options":[{"name":"autocleaninvoice-cycle","type":"string","description":"Perform cleanup of expired invoices every given seconds, or do not autoclean if 0","deprecated":false},{"name":"autocleaninvoice-expired-by","type":"string","description":"If expired invoice autoclean enabled, invoices that have expired for at least this given seconds are cleaned","deprecated":false}],"rpcmethods":[{"name":"autocleaninvoice","usage":"[cycle_seconds] [expired_by]","description":"Set up autoclean of expired invoices. ","long_description":"Perform cleanup every {cycle_seconds} (default 3600), or disable autoclean if 0. Clean up expired invoices that have expired for {expired_by} seconds (default 86400). ","deprecated":false}],"subscriptions":["shutdown"],"hooks":[],"dynamic":false,"notifications":[]} }

this -> "subscriptions":["shutdown"]