Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

investigate: channel state changes two times to AWAITING_UNERLATERAL on force close #4029

Closed
m-schmoock opened this issue Sep 9, 2020 · 1 comment
Assignees
Milestone

Comments

@m-schmoock
Copy link
Collaborator

m-schmoock commented Sep 9, 2020

Issue and Steps to Reproduce

When a channel is closed unilaterally the channel changes the state to AWAITING_UNERLATERAL two times, which means
the second time the channel is already in that state.

This was discovered when implementing tests for #4020

See 160c564 for the 'fix' to suppress the duplicated event notification.

@m-schmoock
Copy link
Collaborator Author

m-schmoock commented Oct 26, 2020

Since we currently save the channel state to the database on each state change (for good reason), we can't skip duplicated updates without selectively checking the database state. The duplicated state changes came from the onchain watchers in onchain_control.c and thechannel_fail_permanent that is used throughout the code.

Addressing this seems over-engineering to me, so we are better off by simply suppressing reaching out duplicated events to the API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants