Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update job status on failed download and ensure all input files are uploaded to S3 #181

Merged
merged 13 commits into from
Jun 26, 2024

Conversation

Eo300
Copy link
Collaborator

@Eo300 Eo300 commented Jun 21, 2024

Resolves #180

Changes

Job Control

  • If input file fails to download, update the status JSON as "failed" before exiting

Job Service (lambda)

  • Fixed bug where sanitized input file names weren't uploaded to S3 (updated tests to cover this scenario)

Eo300 added 6 commits June 19, 2024 12:23
- removed dollar-sign from bash command
- implemented logic to properly copy input-bucket files if filename gets sanitized
…cket

- Covers use case where input file name needs to be sanitized
- Updated moto decorators to comply with most recent version
@Eo300 Eo300 added bug Something isn't working core Required to build base system labels Jun 21, 2024
@Eo300 Eo300 self-assigned this Jun 21, 2024
@Eo300 Eo300 requested review from sobolevnrm and mmacduff June 21, 2024 22:33
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 92.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 75.47%. Comparing base (df5e415) to head (de8f269).

Current head de8f269 differs from pull request most recent head 1fc5116

Please upload reports for the commit 1fc5116 to get more accurate results.

Files Patch % Lines
lambda_services/job_service/launcher/weboptions.py 83.33% 3 Missing ⚠️
lambda_services/job_service/job_service.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #181      +/-   ##
==========================================
+ Coverage   72.77%   75.47%   +2.69%     
==========================================
  Files           9       10       +1     
  Lines         753      791      +38     
==========================================
+ Hits          548      597      +49     
+ Misses        205      194      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Eo300 Eo300 removed the request for review from sobolevnrm June 22, 2024 00:18
@Eo300 Eo300 merged commit 6543a58 into main Jun 26, 2024
5 checks passed
@Eo300 Eo300 deleted the Eo300/issue_180 branch June 27, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core Required to build base system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Job hangs when it fails to download input file
1 participant