Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Where is guava library used? #52

Closed
Ali-RS opened this issue Mar 25, 2023 · 3 comments · Fixed by #61
Closed

[Question] Where is guava library used? #52

Ali-RS opened this issue Mar 25, 2023 · 3 comments · Fixed by #61
Labels
dependencies Dependencies related stuff question Further information is requested

Comments

@Ali-RS
Copy link
Contributor

Ali-RS commented Mar 25, 2023

Hi,

Curious to know where google guava library is used? And if it was necessary?
Because its size is relatively large ( 2.9 MB).

https://github.com/Software-Hardware-Codesign/jme-alloc/blob/78067432ebea30ac23b711e0a417d9ede571d777/jme3-alloc/build.gradle#L75

@pavly-gerges
Copy link
Member

The 'Gradle 'init' task' produces it by default, my suspicion is that it's used by the JUnit test API, however, the output jar doesn't include any of google guava libraries, I think that may be the jre is different from the guava-core, but idk, I have never used google-guava library.

@pavly-gerges pavly-gerges added the question Further information is requested label Mar 25, 2023
@Ali-RS
Copy link
Contributor Author

Ali-RS commented Mar 25, 2023

If it is only used by tests then you should change it to testImplementation or something, else it will be fetched by gradle for any app that uses jme3-alloc.

I think that may be the jre is different from the guava-core

31.1-jre is for desktop apps, there is also 31.1-android version for android.

@pavly-gerges
Copy link
Member

Thanks, I will look into this as soon before releasing the 1.0.0-beta.

@pavly-gerges pavly-gerges added the dependencies Dependencies related stuff label Mar 25, 2023
@pavly-gerges pavly-gerges pinned this issue Mar 25, 2023
@pavly-gerges pavly-gerges linked a pull request Mar 26, 2023 that will close this issue
@pavly-gerges pavly-gerges unpinned this issue Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Dependencies related stuff question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants