diff --git a/qiskit_algorithms/amplitude_estimators/ae.py b/qiskit_algorithms/amplitude_estimators/ae.py index 91521eed..507c3770 100644 --- a/qiskit_algorithms/amplitude_estimators/ae.py +++ b/qiskit_algorithms/amplitude_estimators/ae.py @@ -98,7 +98,7 @@ def __init__( self.quantum_instance = quantum_instance # get parameters - self._m = num_eval_qubits # pylint: disable=invalid-name + self._m = num_eval_qubits self._M = 2**num_eval_qubits # pylint: disable=invalid-name self._iqft = iqft diff --git a/qiskit_algorithms/amplitude_estimators/estimation_problem.py b/qiskit_algorithms/amplitude_estimators/estimation_problem.py index d38c3c0e..93b02991 100644 --- a/qiskit_algorithms/amplitude_estimators/estimation_problem.py +++ b/qiskit_algorithms/amplitude_estimators/estimation_problem.py @@ -201,7 +201,6 @@ def rescale(self, scaling_factor: float) -> "EstimationProblem": # add the scaling qubit to the good state qualifier def is_good_state(bitstr): - # pylint: disable=not-callable return self.is_good_state(bitstr[1:]) and bitstr[0] == "1" # rescaled estimation problem diff --git a/qiskit_algorithms/eigen_solvers/numpy_eigen_solver.py b/qiskit_algorithms/eigen_solvers/numpy_eigen_solver.py index 538494c0..9faf6364 100755 --- a/qiskit_algorithms/eigen_solvers/numpy_eigen_solver.py +++ b/qiskit_algorithms/eigen_solvers/numpy_eigen_solver.py @@ -28,9 +28,6 @@ logger = logging.getLogger(__name__) -# pylint: disable=invalid-name - - class NumPyEigensolver(Eigensolver): r""" Pending deprecation: NumPy Eigensolver algorithm. diff --git a/qiskit_algorithms/eigensolvers/numpy_eigensolver.py b/qiskit_algorithms/eigensolvers/numpy_eigensolver.py index 41af1708..c09f4bc9 100755 --- a/qiskit_algorithms/eigensolvers/numpy_eigensolver.py +++ b/qiskit_algorithms/eigensolvers/numpy_eigensolver.py @@ -29,7 +29,6 @@ from ..list_or_dict import ListOrDict logger = logging.getLogger(__name__) -# pylint: disable=invalid-name FilterType = Callable[[Union[List, np.ndarray], float, Optional[ListOrDict[float]]], bool] diff --git a/qiskit_algorithms/eigensolvers/vqd.py b/qiskit_algorithms/eigensolvers/vqd.py index 4fc692bc..c0115273 100644 --- a/qiskit_algorithms/eigensolvers/vqd.py +++ b/qiskit_algorithms/eigensolvers/vqd.py @@ -265,9 +265,7 @@ def compute_eigenvalues( # TODO: add gradient support after FidelityGradients are implemented if callable(self.optimizer): - opt_result = self.optimizer( # pylint: disable=not-callable - fun=energy_evaluation, x0=initial_point, bounds=bounds - ) + opt_result = self.optimizer(fun=energy_evaluation, x0=initial_point, bounds=bounds) else: # we always want to submit as many estimations per job as possible for minimal # overhead on the hardware diff --git a/qiskit_algorithms/gradients/finite_diff_estimator_gradient.py b/qiskit_algorithms/gradients/finite_diff_estimator_gradient.py index 4b35d4ef..40ba2f65 100644 --- a/qiskit_algorithms/gradients/finite_diff_estimator_gradient.py +++ b/qiskit_algorithms/gradients/finite_diff_estimator_gradient.py @@ -31,7 +31,6 @@ from ..exceptions import AlgorithmError if sys.version_info >= (3, 8): - # pylint: disable=no-name-in-module, ungrouped-imports from typing import Literal else: from typing_extensions import Literal diff --git a/qiskit_algorithms/gradients/finite_diff_sampler_gradient.py b/qiskit_algorithms/gradients/finite_diff_sampler_gradient.py index 3cec0e8e..0bec48fb 100644 --- a/qiskit_algorithms/gradients/finite_diff_sampler_gradient.py +++ b/qiskit_algorithms/gradients/finite_diff_sampler_gradient.py @@ -30,7 +30,7 @@ from ..exceptions import AlgorithmError if sys.version_info >= (3, 8): - # pylint: disable=no-name-in-module, ungrouped-imports + # pylint: disable=ungrouped-imports from typing import Literal else: from typing_extensions import Literal diff --git a/qiskit_algorithms/gradients/utils.py b/qiskit_algorithms/gradients/utils.py index 5fd8abd4..02191fb2 100644 --- a/qiskit_algorithms/gradients/utils.py +++ b/qiskit_algorithms/gradients/utils.py @@ -10,8 +10,6 @@ # copyright notice, and modified files need to carry a notice indicating # that they have been altered from the originals. -# pylint: disable=invalid-name - """ Utility functions for gradients """ diff --git a/qiskit_algorithms/minimum_eigensolvers/sampling_vqe.py b/qiskit_algorithms/minimum_eigensolvers/sampling_vqe.py index 684252f5..832abdca 100755 --- a/qiskit_algorithms/minimum_eigensolvers/sampling_vqe.py +++ b/qiskit_algorithms/minimum_eigensolvers/sampling_vqe.py @@ -210,7 +210,6 @@ def compute_minimum_eigenvalue( start_time = time() if callable(self.optimizer): - # pylint: disable=not-callable optimizer_result = self.optimizer(fun=evaluate_energy, x0=initial_point, bounds=bounds) else: # we always want to submit as many estimations per job as possible for minimal diff --git a/qiskit_algorithms/optimizers/adam_amsgrad.py b/qiskit_algorithms/optimizers/adam_amsgrad.py index c1c9a64b..ccdacbdd 100644 --- a/qiskit_algorithms/optimizers/adam_amsgrad.py +++ b/qiskit_algorithms/optimizers/adam_amsgrad.py @@ -201,7 +201,6 @@ def load_params(self, load_dir: str) -> None: }, since="0.19.0", ) - # pylint: disable=arguments-differ def minimize( self, fun: Callable[[POINT], float], diff --git a/qiskit_algorithms/optimizers/optimizer.py b/qiskit_algorithms/optimizers/optimizer.py index 3ade5b08..c9201bd8 100644 --- a/qiskit_algorithms/optimizers/optimizer.py +++ b/qiskit_algorithms/optimizers/optimizer.py @@ -26,7 +26,7 @@ from qiskit.algorithms.algorithm_result import AlgorithmResult if sys.version_info >= (3, 8): - # pylint: disable=no-name-in-module, ungrouped-imports + # pylint: disable=ungrouped-imports from typing import Protocol else: from typing_extensions import Protocol @@ -41,7 +41,7 @@ class OptimizerResult(AlgorithmResult): def __init__(self) -> None: super().__init__() - self._x = None # pylint: disable=invalid-name + self._x = None self._fun = None self._jac = None self._nfev = None diff --git a/qiskit_algorithms/optimizers/scipy_optimizer.py b/qiskit_algorithms/optimizers/scipy_optimizer.py index 3d6bad2f..b9bde78f 100644 --- a/qiskit_algorithms/optimizers/scipy_optimizer.py +++ b/qiskit_algorithms/optimizers/scipy_optimizer.py @@ -58,7 +58,6 @@ def __init__( kwargs: additional kwargs for scipy.optimize.minimize. max_evals_grouped: Max number of default gradient evaluations performed simultaneously. """ - # pylint: disable=super-init-not-called self._method = method.lower() if isinstance(method, str) else method # Set support level if self._method in self._bounds_support_methods: diff --git a/qiskit_algorithms/optimizers/steppable_optimizer.py b/qiskit_algorithms/optimizers/steppable_optimizer.py index 92877713..2330d65d 100644 --- a/qiskit_algorithms/optimizers/steppable_optimizer.py +++ b/qiskit_algorithms/optimizers/steppable_optimizer.py @@ -59,7 +59,7 @@ class OptimizerState: """ - x: POINT # pylint: disable=invalid-name + x: POINT """Current optimization parameters.""" fun: Optional[Callable[[POINT], float]] """Function being optimized.""" diff --git a/qiskit_algorithms/phase_estimators/phase_estimation.py b/qiskit_algorithms/phase_estimators/phase_estimation.py index bf18efcd..83b446e7 100644 --- a/qiskit_algorithms/phase_estimators/phase_estimation.py +++ b/qiskit_algorithms/phase_estimators/phase_estimation.py @@ -243,7 +243,6 @@ def estimate_from_pe_circuit( self._num_evaluation_qubits, circuit_result=circuit_result, phases=phases ) - # pylint: disable=missing-param-doc def estimate( self, unitary: QuantumCircuit, diff --git a/test/minimum_eigensolvers/test_qaoa.py b/test/minimum_eigensolvers/test_qaoa.py index b512664e..de1bbe5e 100644 --- a/test/minimum_eigensolvers/test_qaoa.py +++ b/test/minimum_eigensolvers/test_qaoa.py @@ -33,8 +33,8 @@ from qiskit.primitives import Sampler from qiskit.utils import algorithm_globals -I = PauliSumOp.from_list([("I", 1)]) # pylint: disable=invalid-name -X = PauliSumOp.from_list([("X", 1)]) # pylint: disable=invalid-name +I = PauliSumOp.from_list([("I", 1)]) +X = PauliSumOp.from_list([("X", 1)]) W1 = np.array([[0, 1, 0, 1], [1, 0, 1, 0], [0, 1, 0, 1], [1, 0, 1, 0]]) P1 = 1 diff --git a/test/minimum_eigensolvers/test_sampling_vqe.py b/test/minimum_eigensolvers/test_sampling_vqe.py index e28908bf..8e364e38 100644 --- a/test/minimum_eigensolvers/test_sampling_vqe.py +++ b/test/minimum_eigensolvers/test_sampling_vqe.py @@ -33,7 +33,7 @@ from qiskit.utils import algorithm_globals -# pylint: disable=invalid-name, unused-argument +# pylint: disable=invalid-name def _mock_optimizer(fun, x0, jac=None, bounds=None, inputs=None): """A mock of a callable that can be used as minimizer in the VQE. diff --git a/test/optimizers/test_spsa.py b/test/optimizers/test_spsa.py index 8e48e280..949f2aa0 100644 --- a/test/optimizers/test_spsa.py +++ b/test/optimizers/test_spsa.py @@ -258,7 +258,6 @@ def objective(x): def test_point_sample(self): """Test point sample function in QNSPSA""" - # pylint: disable=invalid-name def fidelity(x, _y): x = np.asarray(x) diff --git a/test/test_grover.py b/test/test_grover.py index f0363b6d..be57e2dc 100644 --- a/test/test_grover.py +++ b/test/test_grover.py @@ -80,7 +80,6 @@ def is_good_state(bitstr): problem = AmplificationProblem(oracle, is_good_state=is_good_state) expected = [state in ["01", "11"] for state in possible_states] - # pylint: disable=not-callable actual = [problem.is_good_state(state) for state in possible_states] self.assertListEqual(expected, actual)