Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix installation of JS packages, prevent silent failures (closes #22) #23

Merged
merged 1 commit into from
Mar 3, 2021

Conversation

ElMassimo
Copy link
Owner

Description 📖

This pull request fixes a problem in the installation script, caused by an incorrect npx command.

The ni package has multiple binaries, so it's necessary to disambiguate which command to run.

Also, it adds the --no-install flag when running npx, ensuring build and dev commands fail early if the packages have not been installed.

Additional information is now logged in bin/vite info, to simplify debugging.

New Errors 📜

Building with Vite ⚡️
Build with Vite failed:
npm ERR! canceled

❌ Check that vite and vite-plugin-ruby are in devDependencies and have been installed.

@ElMassimo ElMassimo force-pushed the fix/packages-installation branch from 76defcf to 6a46340 Compare March 3, 2021 16:27
@ElMassimo ElMassimo merged commit d972e6f into main Mar 3, 2021
@ElMassimo ElMassimo deleted the fix/packages-installation branch March 3, 2021 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant