Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhandled message type 'MESSAGE_ACK' #343

Open
pabs3 opened this issue May 31, 2021 · 0 comments
Open

Unhandled message type 'MESSAGE_ACK' #343

pabs3 opened this issue May 31, 2021 · 0 comments

Comments

@pabs3
Copy link
Collaborator

pabs3 commented May 31, 2021

While debugging the crash issue, I noticed that the purple-discord function discord_process_dispatch is not able to handle MESSAGE_ACK messages. I'm not sure about the appropriate response to them, if libpurple has some sort of API for marking messages as delivered, probably purple-discord should call that. Alternately MESSAGE_ACK messages could just be ignored.

PS: I noticed a number of issues in other projects relating to MESSAGE_ACK support, perhaps some of them will indicate the purpose of this message type.

Rapptz/discord.py#1851
discord-net/Discord.Net#84
terminal-discord/weechat-discord#29
Kiskae/DiscordKt#2
discordrb/discordrb#211
discord-jda/JDA#14

(05:31:10) discord: got frame data: {"t":"MESSAGE_ACK","s":322,"op":0,"d":{"version":33647,"message_id":<removed>,"channel_id":<removed>}}
(05:31:10) discord: Unhandled message type 'MESSAGE_ACK'
(06:47:01) discord: got frame data: {"t":"MESSAGE_ACK","s":434,"op":0,"d":{"version":33649,"message_id":<removed>,"channel_id":<removed>}}
(06:47:01) discord: Unhandled message type 'MESSAGE_ACK'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant