-
-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add DateTime module #3296
add DateTime module #3296
Conversation
🦋 Changeset detectedLatest commit: e4871d6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 31 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
869c1fa
to
0092e45
Compare
Exciting! Would you consider a type for representing a Date with no time component? |
Maybe as a separate module in a new PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful api design. Nice.
One nitpick: I don't like the I'm wondering if we should align even more with the Temporal API suggestion and also use |
Trying out
I'll stick with |
Sounds much better imho. Especially in the |
80c8158
to
361d897
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hot.
361d897
to
838e750
Compare
9ee184a
to
646313e
Compare
162d317
to
cb8300c
Compare
838e750
to
4b25a1e
Compare
78fe811
to
e4871d6
Compare
Co-authored-by: Tim Smart <tim.smart@arisechurch.com>
Co-authored-by: Tim Smart <tim.smart@arisechurch.com>
Co-authored-by: Tim Smart <tim.smart@arisechurch.com>
Co-authored-by: Tim Smart <tim.smart@arisechurch.com>
Co-authored-by: Tim Smart <tim.smart@arisechurch.com>
Co-authored-by: Tim Smart <tim.smart@arisechurch.com>
Co-authored-by: Tim Smart <tim.smart@arisechurch.com>
Co-authored-by: Tim Smart <tim.smart@arisechurch.com>
Co-authored-by: Tim Smart <tim.smart@arisechurch.com>
Co-authored-by: Tim Smart <tim.smart@arisechurch.com>
Co-authored-by: Tim Smart <tim.smart@arisechurch.com>
No description provided.