-
-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SF with no switch assigned becomes ghost function for life cycle and isn't written to .yml #3696
Comments
This is a bit of a weird one... At present if you don't assign a trigger/switch... the special function effectively does not exist. Perhaps the UI could demonstrate this better by hiding all the other elements until the switch condition is changed away from While 2.9 has a completely different adding mechanism... it still has this "remember how you last configured the SF dialog" hangover... not sure whether to consider this as an actual bug or a "save your from yourself stupidity when you cancel by mistake" feature 😆 With #3024 in place, this would IMO definitely be a bug - i.e. it should be saved, but you can't enable it if there is no trigger defined. |
Understood, but If you consider the current behavior a feature consequently the unfinished SF should show up in the SF list and be written to yml until there is a different solution. |
#3024 is in place now. So this is a bug now too, isn't it. Or was it fixed along the way? |
Only if this is still reproducible post #3024 - that PR should have prevented this being possible IIRC |
@pfeerick still reproducible in 2.9 and 2.10. The added enable switch doesn't make a difference. The SF remains a ghost as long as there is no trigger defined. And 2.10 allows enabling without trigger |
@pfeerick hooray, we made the 1yr mark |
Is there an existing issue for this problem?
What part of EdgeTX is the focus of this bug?
Transmitter firmware
Current Behavior
Creating a SF and leaving the Switch at the "---" default will not be correctly displayed after creation and will not be stored permanently.
Expected Behavior
SF should be visible in SF list and permanently stored
Steps To Reproduce
Version
2.8.3
Transmitter
Radiomaster TX16S / TX16SMK2
Operating System (OS)
No response
OS Version
No response
Anything else?
No response
The text was updated successfully, but these errors were encountered: