Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal module not set to ISRM up upgrade of on X lite PRO #1942

Closed
1 task done
timemaster5 opened this issue May 6, 2022 · 5 comments · Fixed by #5236
Closed
1 task done

Internal module not set to ISRM up upgrade of on X lite PRO #1942

timemaster5 opened this issue May 6, 2022 · 5 comments · Fixed by #5236
Labels
bug 🪲 Something isn't working triage Bug report awaiting review / sorting

Comments

@timemaster5
Copy link

Is there an existing issue for this problem?

  • I have searched the existing issues

What part of EdgeTX is the focus of this bug?

Transmitter firmware

Current Behavior

I've built the latest edgetx 2.7.0 f79978b with bluetooth,crossfire, ghost, noheli, internalmulti, internalaccess, multimodule and luac options, but I can't choose an ISRM module in the model settings.

Expected Behavior

As in the previous versions, I would also like to use the internal ISRM2 module on 2.7.0 :)

Steps To Reproduce

The only thing is to download the official firmware release and test it on X lite PRO. But to be on the same page, I use these options: cmake -Wno-dev -DPCB=XLITES -DHELI=NO -DLUA=YES -DGVARS=YES -DFONT=SQT5 -DMODULE_PROTOCOL_FLEX=YES -DAFHDS3=NO ../

Version

2.7.0

Transmitter

FrSky X-Lite / S / Pro

Anything else?

No response

@timemaster5 timemaster5 added bug 🪲 Something isn't working triage Bug report awaiting review / sorting labels May 6, 2022
@pfeerick
Copy link
Member

pfeerick commented May 7, 2022

So just to double check, when you go into SYS -> Hardware -> Internal RF ISRM isn't an option there? I don't have that hardware, so am relying on Simulator for initial analysis

companion_QvUOTyHdYA.mp4

@timemaster5
Copy link
Author

timemaster5 commented May 7, 2022

All right, stupid me. I didn't come across this option before on this radio. So when I set the ISRM there, all is fine, except I still have to go into ISRM options to select an external antenna. Even though I don't have an XJT, I immediately fell in love with the option to ask whether I use an external or internal antenna at the beginning :)

I was upgrading and saw the updating EEPROM message. Maybe that's why I wasn't expecting that, and not being able to select ACCESS protocol in the model menu gave me the impression that the support is just not there.

So is it really a bug? I mean, is it supposed to migrate these settings? I know this was a huge update. Maybe it wasn't possible to migrate everything.

And thank you very much for it. It works great, and many options are now much more straightforward. For example, the Hardware menu is now more helpful. I really didn't need to do anything in there before.

@raphaelcoeffic
Copy link
Member

@timemaster5 so what you’re basically saying is that the internal module setting was not correct after upgrade, right?

@raphaelcoeffic
Copy link
Member

By the way, can you please provide the exact command you used with CMake? It might be related to the default module & CMake.

@timemaster5
Copy link
Author

timemaster5 commented May 7, 2022

@timemaster5 so what you’re basically saying is that the internal module setting was not correct after upgrade, right?

yes, I've lost bound receivers also..
EDIT: I haven't lost my bindings actually, it seemed so at the first sight, but when I powered the model on, all was ok. I lost only failsafe settings.

By the way, can you please provide the exact command you used with CMake? It might be related to the default module & CMake.

$ cmake -LH ../ > cmake-options.txt
$ cmake -Wno-dev -DPCB=XLITES -DHELI=NO -DLUA=YES -DGVARS=YES -DFONT=SQT5 -DMODULE_PROTOCOL_FLEX=YES -DAFHDS3=NO ../
$ make -j`nproc` firmware

@pfeerick pfeerick changed the title xlites 2.7.0 no isrm internal module available on X lite PRO Internal module not set to ISRM up upgrade of on X lite PRO Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working triage Bug report awaiting review / sorting
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants