Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

Tab switching on a user's page is causing the user details section to flicker #5003

Closed
FrozenHearth opened this issue Feb 21, 2023 · 9 comments · Fixed by #5158
Closed

Tab switching on a user's page is causing the user details section to flicker #5003

FrozenHearth opened this issue Feb 21, 2023 · 9 comments · Fixed by #5158
Assignees
@psavan1655
Labels
💻 aspect: code undefined 🛠 goal: fix undefined 🔢 points: 5 undefined 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned)

Comments

@FrozenHearth
Copy link
Contributor

Description

When we're switching between Milestones and My Links tabs, the user details flickers. I believe this is due to the whole component re-rendering on tab switch.

I think a fix would be to prevent the whole [username.js] page from re-rendering.

Screenshots

Screen.Recording.2023-02-21.at.10.50.14.PM.mov

Additional information

No response
@FrozenHearth FrozenHearth added 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet) 🛠 goal: fix undefined labels Feb 21, 2023
@github-actions
Copy link
Contributor

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

@PratikDey
Copy link
Contributor

Hi, I understood the problem and would like to contribute to this issue.
Can you please direct me in which component I have to look into?

@SaraJaoude SaraJaoude added 🔢 points: 5 undefined 💻 aspect: code undefined 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned) and removed 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet) labels Feb 27, 2023
@SaraJaoude
Copy link
Member

Hi, I understood the problem and would like to contribute to this issue.
Can you please direct me in which component I have to look into?

@PratikDey thank you for enthusiasm to contribute but as this requires some debugging we will assign it to someone who can debug the problem.

@SaraJaoude SaraJaoude mentioned this issue Feb 28, 2023
Closed
@psavan1655
Copy link
Contributor

Hi, as discussed in #5126 . I have already resolved this issue, so i would like to take this issue.

@SaraJaoude
Copy link
Member

Hi, as discussed in #5126 . I have already resolved this issue, so i would like to take this issue.

@psavan1655 I have assigned this to you

@psavan1655
Copy link
Contributor

Thanks.

@psavan1655 psavan1655 mentioned this issue Feb 28, 2023
Merged
6 tasks
@psavan1655
Copy link
Contributor

Raised PR for the Fix.
PR #5158

@FrozenHearth
Copy link
Contributor Author

Hi @psavan1655 Thanks for the fix. Caught an edge case, please check here: #5158 (comment)

@github-actions
Copy link
Contributor

Reviewpad Report

📜 Executed actions

No actions executed

@psavan1655 psavan1655 mentioned this issue Mar 18, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@psavan1655 psavan1655

Labels
💻 aspect: code undefined 🛠 goal: fix undefined 🔢 points: 5 undefined 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Memoize user profile for performance improvement psavan1655/LinkFree
4 participants
@FrozenHearth @psavan1655 @PratikDey @SaraJaoude