Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problem with outputnode function #95

Closed
HughMurrell opened this issue Apr 23, 2024 · 1 comment · Fixed by #96
Closed

problem with outputnode function #95

HughMurrell opened this issue Apr 23, 2024 · 1 comment · Fixed by #96

Comments

@HughMurrell
Copy link

I am using Phylo v0.5.1 and when I list the nodes of a tree, the "internal node" and "leaf node" labels are interchanged.
Here is a minimal demonstration:

This input:

using Phylo
simpletree = parsenewick("(ant:17, (bat:31, cow:22):7, dog:22, (elk:33, fox:12):40);")
collect(Phylo.nodeiter(simpletree))

produced this output:

9-element Vector{RecursiveNode{OneRoot, String, Dict{String, Any}, Dict{String, Any}, PolytomousBranching, Float64}}:
internal node 'ant'
internal node 'bat'
internal node 'cow'
leaf node 'Node 4'
internal node 'dog'
internal node 'elk'
internal node 'fox'
leaf node 'Node 8'
root node 'Node 9'

The "root node" label is correct but the "internal node" and "leaf node" labels are interchanged.

I think the problem is somewhere in show.jl in the src directory, probably with the outputnode function.

Also, the link to this issues page in your README is broken.

Thanks for all the good work,
Hugh Murrell

@richardreeve
Copy link
Member

Thanks @HughMurrell - that's really easily fixed I hope (and sorry about the issues link!). I'm just going to merge it and release v0.5.2 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants