-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parsenexus() tree validation fails if '-' in TaxLabels #75
Comments
Sorry @isaacovercast - I missed this when you posted it. I'll have a look at it as soon as I can. I've been trying to find the time to completely rewrite the parser because it's such a mess, but it's just so much work! |
Thanks for taking a look at it! No rush for me, I just edited the nex by hand. |
Hi @isaacovercast - I realise this is long after you raised this issue, but I've just been looking at it, and I can't see any evidence that this is in fact legal nexus syntax. |
@richardreeve Thank you for sharing the original paper, fun to go back and read through it! I had no idea about the |
Tested with Phylo.jl v0.4.21
When loading a nexus file, if any TaxLabels in the Taxa block contain dashes ('-') then the
open
operation will fail with the following messages:Steps to reproduce:
Save the following file as
wat.nexus
:In Julia REPL call:
ts = open(parsenexus, Phylo.path("wat.nexus"))
The text was updated successfully, but these errors were encountered: