Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to save/write a tree in Newick format #61

Closed
diegozea opened this issue Aug 17, 2021 · 2 comments
Closed

Add function to save/write a tree in Newick format #61

diegozea opened this issue Aug 17, 2021 · 2 comments

Comments

@diegozea
Copy link

I think it will be useful, particularly to share the tree between sessions and programs.

@richardreeve
Copy link
Member

richardreeve commented Aug 17, 2021

Yes, it's a good idea. I also want to write an entirely new parser for newick and nexus format, because the current one is a mess, and it looks like CombinedParsers.jl can handle recursion (finally, a julia parser that can!) - and something to convert between PhyloNetwork's format and this one, possibly just via a wrapper of some kind:

struct TreeWrapper{Tree} <: AbstractTree
  tree::Tree
end

where the wrapper implements our interface. From there I was wondering whether there was a sensible way of allowing us to traverse a tree to allow us to convert between any file format or tree format via a common interface... essentially iterating over the one you have while creating the other one. Just speculating really, but it would solve a lot of problems...

@richardreeve
Copy link
Member

This was solved in #88.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants