Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add Gitlens Fork before it was owned by GitKraken #680

Open
lamyergeier opened this issue May 6, 2023 · 7 comments
Open

Please add Gitlens Fork before it was owned by GitKraken #680

lamyergeier opened this issue May 6, 2023 · 7 comments

Comments

@lamyergeier
Copy link

lamyergeier commented May 6, 2023

This extension is available on vscode at : [GitLess - Visual Studio Marketplace](https://marketplace.visualstudio.com/items?itemName=maattdd.gitless)

Repository: maattdd/vscode-gitlens

@filiptronicek
Copy link
Member

Hi there @lamyergeier 👋!

I think there is no harm in one-time publishing this extension, but does it really do what you suggest it does? I see GitKraken links in this version already 🤔
image

@lamyergeier
Copy link
Author

lamyergeier commented May 10, 2023

@filiptronicek

Yes there are Gitkraken links but all features are free upto that git commit. Read: [GitLess - Visual Studio Marketplace](https://marketplace.visualstudio.com/items?itemName=maattdd.gitless)

@filiptronicek
Copy link
Member

@lamyergeier can you check that https://open-vsx.org/extension/maattdd/gitless is published correctly?

@lamyergeier
Copy link
Author

@filiptronicek It is not correct. When installed in Codium it shows extension version as v12. While when I install the extension in Microsoft VSCode it shows v11.7 as follows

image

@filiptronicek
Copy link
Member

@lamyergeier ok, I can unpublish this version. Do you know where the extension would be published from exactly? I don't see any difference in the fork - no commits added by @maattdd. I'm looking for the actual source code from which they published it.

@GitMensch
Copy link
Contributor

Hm, I also see that - the version in the marketplace just doesn't have any matching branch / tag in the repo - so there is no use in the extra publishing from the repo.

Also open-vsx already include the "completely free" version https://open-vsx.org/extension/eamodio/gitlens/11.7.0 (and with the missing additional commits and an "active" fork where changes are actually done (for example each change from the official version that doesn't change anything in the "plus" directory could be merged in - because this is the sole directory that has a different license.

@filiptronicek
Copy link
Member

Also open-vsx already include the "completely free" version

Thanks for pointing that out @GitMensch, we really have been publishing that extension for a long time now haha!

If we cannot get the actual source code, I think I'll raise a removal request for the extension, as it is published incorrectly and it doesn't seem we'll resolve this here by ourselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants