Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflicting case-insensitive resource filenames #5

Closed
falkTX opened this issue Dec 11, 2021 · 3 comments · Fixed by #6
Closed

Conflicting case-insensitive resource filenames #5

falkTX opened this issue Dec 11, 2021 · 3 comments · Fixed by #6

Comments

@falkTX
Copy link
Contributor

falkTX commented Dec 11, 2021

Hi there.
Just noticed that your modules, when installed on macOS and Windows (or any other system with case-insensitive filenames) will have issues due to how the files are named.
You have "screw.svg" and "Screw.svg" for example. Only one of those is possible on Windows and default macOS installs.
So the plugin ends up in undefined behaviour regarding which files are actually used.

image

If they are meant to be the same file, the wrong ones should be deleted from the repo.

@falkTX
Copy link
Contributor Author

falkTX commented Dec 11, 2021

According to https://github.com/EaterOfSheep/Extratone/blob/main/src/plugin.hpp#L27 the correct file is screw.svg, so the Screw.svg can be deleted..?

@offthesky
Copy link

responding to dromer from issue #80:

These are not duplicate filenames, but it seems windows case-insensitivity is being a PITA?
Is there an actual issue you are seeing with these?

upon extracting via winrar i just chose yes to all, it automatically used the larger files (so it picked screw.svg & XtrtnKnob.svg). i've loaded up all the modules and nothing looks amiss. haven't had a chance to really use them yet though.

@EaterOfSheep
Copy link
Owner

Thank you very much! This explains why, in videos, other users didn't have my custom-knob graphics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants