Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ETL_USING_LEGACY_VARIANT Is always getting evaluated to 1 #937

Closed
drewr95 opened this issue Jul 30, 2024 · 3 comments
Closed

ETL_USING_LEGACY_VARIANT Is always getting evaluated to 1 #937

drewr95 opened this issue Jul 30, 2024 · 3 comments
Assignees
@jwellbelove

Comments

@drewr95
Copy link
Contributor

drewr95 commented Jul 30, 2024

It seems that ETL_USING_LEGACY_VARIANT is always getting evaluated to 1 for me. I do not have ETL_USE_LEGACY_VARIANT defined, so the !ETL_USING_CPP11 must be getting evaluated to true. I believe this is because these macros are defined before determining compiler versions.
 
image
@drewr95
Copy link
Contributor Author

drewr95 commented Jul 30, 2024

Looks like VSCode is confirming this:
image

If we don't determine compiler version til line 153 (profiles/determine_compiler_version.h), how can ETL_USING_CPP11 be evaluated?

@drewr95
Copy link
Contributor Author

drewr95 commented Jul 30, 2024

Yeah, can confirm, if I move that macro below determining compiler version my builds work again

@drewr95 drewr95 mentioned this issue Jul 30, 2024
Merged
@jwellbelove jwellbelove self-assigned this Jul 30, 2024
@jwellbelove
Copy link
Contributor

Fixed 20.39.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jwellbelove jwellbelove

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jwellbelove @drewr95