Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the word 'obs' from CMORizer scripts #1407

Closed
bouweandela opened this issue Oct 23, 2019 · 5 comments
Closed

Remove the word 'obs' from CMORizer scripts #1407

bouweandela opened this issue Oct 23, 2019 · 5 comments
Assignees

Comments

@bouweandela
Copy link
Member

Since the cmorizer scripts in esmvaltool/cmorizers/obs are the only cmorizer scripts and they are also used for e.g. reanalysis data, I would propose to:

  • Move these scripts one level up, to esmvaltool/cmorizers
  • Rename the command from cmorize_obs to cmorize
  • Get rid of the obs suffix/infix in all other filenames
@valeriupredoi
Copy link
Contributor

valeriupredoi commented Oct 23, 2019

good call! But we have to be careful with the datafinder functionality in the utility script cmorize_obs.py/_assemble_datasets(raw_obs, obs_list) that currently assumes RAWOBS/TierX/DATASET input structure

@mattiarighi
Copy link
Contributor

What about the mip_convert subdirectory. Does it still belong there?

But we have to be careful with the datafinder functionality in the utility script cmorize_obs.py/_assemble_datasets(raw_obs, obs_list) that currently assumes RAWOBS/TierX/DATASET input structure

But @bouweandela suggestion does not affect the input data structure, does it?

@bouweandela
Copy link
Member Author

But @bouweandela suggestion does not affect the input data structure, does it?

Indeed the suggestion is about the names used in code/files containing code.

@mattiarighi mattiarighi self-assigned this May 25, 2020
@mattiarighi mattiarighi added this to the v2.0.0 milestone Jun 5, 2020
@bouweandela bouweandela removed this from the v2.0.0 milestone Jun 8, 2020
@bouweandela
Copy link
Member Author

This will probably be superseded by #1657. Removed the v2.0.0 milestone because it seems unlikely that #1657 will be finished in time.

@remi-kazeroni
Copy link
Contributor

This was done in #1657. CMORizer scripts now live in esmvaltool/cmorizers/data/formatters/datasets and are simply named dataset.py or dataset.ncl without using the word "obs". I think this issue can now be closed. Feel free to reopen if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants