Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make preprocessor function volume_statistics lazy #647

Closed
bouweandela opened this issue May 19, 2020 · 2 comments · Fixed by #2436
Closed

Make preprocessor function volume_statistics lazy #647

bouweandela opened this issue May 19, 2020 · 2 comments · Fixed by #2436
Assignees
@valeriupredoi
Labels
enhancement New feature or request preprocessor Related to the preprocessor

Comments

@bouweandela
Copy link
Member

bouweandela commented May 19, 2020 •
edited
Loading

Related to #51
@bouweandela bouweandela added the preprocessor Related to the preprocessor label May 19, 2020
@valeriupredoi
Copy link
Contributor

I'll fix this once #618 gets merged 🍺

@valeriupredoi valeriupredoi self-assigned this May 26, 2020
@bouweandela bouweandela changed the title Preprocessor function volume_statistics is not lazy Make preprocessor function volume_statistics lazy May 26, 2020
@bouweandela bouweandela added the enhancement New feature or request label May 26, 2020
@bouweandela bouweandela mentioned this issue Jun 12, 2020
Open
62 tasks
@bouweandela
Copy link
Member Author

From looking at the code, this preprocessor seems lazy when the iris statistic is lazy and the required cell measures are available. Lazy area weights are needed to make this completely lazy SciTools/iris#5611.

@bouweandela bouweandela mentioned this issue May 26, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valeriupredoi valeriupredoi

Labels
enhancement New feature or request preprocessor Related to the preprocessor
Projects
High priority issues
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make volume calculation in preprocessor function volume_statistics lazy ESMValGroup/ESMValCore
2 participants
@bouweandela @valeriupredoi