-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problems with msftyz data #359
Comments
As of right now, I have written fixes for all the CMIP6 models. They are available here: The fixes are:
|
I know this is rather complicated, but we have to take into account the official CMIP6 Model Output Requirements. There we find (Requirements for coordinate variables, note 12; page 7)
Related is also (Requirements for output variables, note 11; page 11), however, (Requirements for output variables, note 13.f; page 13) talks about The way data should look like is illustrated by (Example 4, page 25). So we see that both EC-Earth3 and the UK models are correct. Your fixes should not be applied because having a variable with the same name as a dimension generally means that the variable is a (dimension) coordinate variable, but that can not be the case here because dimensional coordinates must be numeric (and monotonous). The Good NewsIt's actually very simple to work with this data. Just do a
to get at it. I will look at the other model families now. |
The other models do seem to need some fixes, but they are too involved for me to sort out right now. GeneralWe have to keep clear the concepts of In your fix you write
but this is not renaming the variable from "Vertical W levels" to "depth", instead it is assigning a new Generally speaking, So how do we get the coordinate we want in the most general way?
This will apply all the (rather involved) logic laid out in the CF conventions to identify the vertical coordinate. CNRMlatitude coordinateYou are quite right in your approach to fix it. But I wonder: How did you come up with the new latitudes? Considering that the full grid (cf eg vertical coordinateI think the original GISSLet's leave it for now. IPSLsqueezing is goodvertical coordinateIt applies larger what I said above about CNRM. Only that IPSL is slightly worse with the wrong basin coordinateYour idea is correct, I belief. However, the result should be the same as we already find in EC-Earth and the UK models. |
I'd like to revive this issue. I've encountered further trouble with the derived variable |
In #310 @ledm wrote:
and later
I had a look at the available data on mistral for
msftyz
. Removing duplicates from the above list we havemsftyz
Loads fine in iris
Loads fine in iris
Loads fine in iris
Uses an old version of the data request (see Deal with different data_specs_versions in CMIP6 #159)
Loads fine in iris
Loads fine in iris
Before investigating further, @ledm, what are the problems you are encountering?
The text was updated successfully, but these errors were encountered: