Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concatenate implementation is broken #2248

Closed
zklaus opened this issue Oct 30, 2023 · 0 comments · Fixed by #2247
Closed

Concatenate implementation is broken #2248

zklaus opened this issue Oct 30, 2023 · 0 comments · Fixed by #2247
Labels
bug Something isn't working

Comments

@zklaus
Copy link

zklaus commented Oct 30, 2023

The function _check_time_overlaps first constructs a list of time coordinates from the given cubes, then does an index loop over those, and in the loop body removes cubes based on the index from the cube list.

This way, times are checked that do not correspond to the cube under question and the method can produce wrong results for three or more cubes.

@zklaus zklaus added the bug Something isn't working label Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant