-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How should multi-model statistics work on tas? #1204
Comments
A recipe, which is probably affected by this issue is recipe_flato13ipcc.yml (according to the list in ESMValGroup/ESMValTool#2198 it hasn't been tested for the new core, yet). |
To answer youir 3rd question @zklaus... There is a wider category of variables where you shouldn't make a multi-model mean because the variable has a different meaning for different models. Top level soil moisture (mrsos) is one, because models have different layer thicknesses and soil moisture can have a strong vertical gradient. Dust emission is another, because the algorithm / interpretation of "emission" differs so much between models. As Ruth kind of said just now, caveat usor. |
I still do not know why they introduced the "height" for tas in CMIP6, it may be informative but not very helpful, just causing problems.... |
Ok, sounds like there should be a special case to ignore the scalar height dimension only for |
One suggestion: Would it maybe make sense to add an optional keyword The default value should be if ignore_scalar_coordinates:
for cube in cubes:
for coord in cube.coords(dimensions=()):
cube.remove_coord(coord) |
I started with implementing a test in #1209 to establish the desired behaviour, but interestingly I find that iris already copes with this situation. It averages the coordinate value and sets bounds as well. Multi-model statistics pass just fine. Does someone want to elaborate on a use case that failed for them? |
It seems that this was first diagnosed in #1198 (comment). @valeriupredoi, can you confirm that this is actually a problem? Otherwise we'll close this issue sometime today. |
I'll test if it is still an issue on the modified version of recipe_pv_capacity_factor.yml, where @valeriupredoi saw it first and on a short version of recipe_flato13ipcc.yml only for the first figure, where it could play a role (it uses tas, a multi-model mean and ACCESS1-3 together with many other models). |
Fig 9.2 from recipe_flato13ipcc.yml runs, just produces the Warning:
The same for the modified version of recipe_pv_capacity_factor.yml. |
Thanks for checking @katjaweigel . That warning is harmless. |
Great, thanks @katjaweigel and @Peter9192 ! |
Just out of curiosity: Were there any changes in the code or did this problem disappear by itself? |
As far as I can see there were no changes and this may never have been the problem, rather a similarity in error messages/warnings led to a misdiagnosis. |
Yes, it looks like for different heights for tas there was all the time only a warning, the recipe contained both, different heights for tas and different calendars, gave Warnings for both but failed due to the leap year issue. |
Do we still want to merge #1209? That PR adds a test to verify the behaviour discussed in this PR. It's currently in draft as I was waiting for more elaborate fail cases, but it seems there will be none |
@Peter9192, sounds good. Could you estimate when you have time for it, assign the 2.3.1 or 2.4.0 milestone accordingly, and wrap it up? I'll be happy to do the review. |
More comprehensive metadata handling in the multi-model statistics recently turned up a conceptual issue for multi-model statistics on near-surface temperature (
tas
).This variable is always "near-surface", but different models use slightly different heights, typically 2m or 1.5m.
It seems to be a consensus that a multi-model mean should just be calculated across all models, regardless of the exact height.
Open questions:
:height=2m
?tas
a special case or is this in some way general/an issue for other variables as well?Some aspects of this have been discussed in #1201 and #1198.
The text was updated successfully, but these errors were encountered: