Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to the MEGAN specifier string parser #339

Merged
merged 3 commits into from
Jan 20, 2023

Conversation

fvitt
Copy link
Collaborator

@fvitt fvitt commented Jan 20, 2023

Description of changes

Adds the capability to split up long specifier string in the namelist into multiple lines.
Also provides the capability to specify common coefficients to multiple MEGAN terms like this:

            ... + a*(A + B + C +... ) +...

Specific notes

Contributors other than yourself, if any:

CMEPS Issues Fixed (include github issue #):

Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial)
bfb -- no changes to answers

Any User Interface Changes (namelist or namelist defaults changes)?

Testing performed

ERP_Ln9_Vnuopc.f09_f09_mg17.FC2000climo.cheyenne_intel.cam-outfrq3s_sums (Overall: PASS) details:
ERP_Ln9_Vnuopc.ne30_ne30_mg17.FCnudged.cheyenne_intel.cam-outfrq9s (Overall: PASS) details:
SMS_D_Ln9_Vnuopc.f09_f09_mg17.FC2000climo.cheyenne_intel.cam-outfrq3s_sums (Overall: PASS) details:
SMS_D_Ln9_Vnuopc.f09_f09_mg17.FCts2nudged.cheyenne_intel.cam-outfrq9s_leapday (Overall: PASS) details:
SMS_Ld1_Vnuopc.ne30pg3_ne30pg3_mg17.FC2010climo.cheyenne_intel.cam-outfrq1d (Overall: PASS) details:

        modified:   cesm/nuopc_cap_share/shr_expr_parser_mod.F90
        modified:   cesm/nuopc_cap_share/shr_megan_mod.F90
        modified:   cesm/nuopc_cap_share/shr_megan_mod.F90
        modified:   cesm/nuopc_cap_share/shr_megan_mod.F90
@fvitt fvitt requested a review from jedwards4b January 20, 2023 20:51
@jedwards4b jedwards4b merged commit 1f06c58 into ESCOMP:main Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants