Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify specification of stop_option, rest_option and history_option (cesm only) #313

Merged
merged 4 commits into from
Oct 7, 2022

Conversation

mvertens
Copy link
Collaborator

@mvertens mvertens commented Oct 6, 2022

Description of changes

simplify specification of stop_option, rest_option and hist_option

Specific notes

This PR addresses issue #311
Only the following values are now allowed
none,never,nsteps,nseconds,nminutes,nhours,ndays,nmonths,nyears,date,end

Contributors other than yourself, if any: None

CMEPS Issues Fixed: #311

Are changes expected to change answers? bfb

Any User Interface Changes (namelist or namelist defaults changes)? None

Testing performed

Verified that SMS_Ln9.f19_g17.A.cheyenne_intel if HIST_OPTION is 'nstep', preview_namelist_fails

Hashes used for testing:

@mvertens mvertens marked this pull request as draft October 6, 2022 21:19
@mvertens mvertens changed the title generalize specification of history output (cesm only) simplify specification of stop_option, rest_option and history_option (cesm only) Oct 7, 2022
@mvertens mvertens marked this pull request as ready for review October 7, 2022 01:02
@mvertens
Copy link
Collaborator Author

mvertens commented Oct 7, 2022

@jedwards4b - can you please review again. I decided on a much simpler approach for this.

@jedwards4b
Copy link
Collaborator

Nothing changed?

@mvertens
Copy link
Collaborator Author

mvertens commented Oct 7, 2022

@jedwards4b - sorry - forgot to push back. It should be updated now.

@mvertens mvertens merged commit 962e753 into ESCOMP:master Oct 7, 2022
@mvertens mvertens deleted the feature/generalize_timespec branch June 16, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't run with HIST_OPTION=nstep?
2 participants