From 9fce051718e1d0d2fe9fabb579a0ca3f6f5d0ede Mon Sep 17 00:00:00 2001 From: Pavel Pernatii Date: Thu, 3 Sep 2020 23:10:03 +0300 Subject: [PATCH 1/2] Allowing a name to be an empty string --- src/eosjs-serialize.ts | 2 +- src/tests/eosjs-serialize.test.ts | 7 ------- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/src/eosjs-serialize.ts b/src/eosjs-serialize.ts index b9773e94a..5918ce2a0 100644 --- a/src/eosjs-serialize.ts +++ b/src/eosjs-serialize.ts @@ -320,7 +320,7 @@ export class SerialBuffer { if (typeof s !== 'string') { throw new Error('Expected string containing name'); } - const regex = new RegExp(/^[.1-5a-z]{1,12}[.1-5a-j]?$/); + const regex = new RegExp(/^[.1-5a-z]{0,12}[.1-5a-j]?$/); if (!regex.test(s)) { throw new Error('Name should be less than 13 characters, or less than 14 if last character is between 1-5 or a-j, and only contain the following symbols .12345abcdefghijklmnopqrstuvwxyz'); // eslint-disable-line } diff --git a/src/tests/eosjs-serialize.test.ts b/src/tests/eosjs-serialize.test.ts index 011fdc613..9178741e1 100644 --- a/src/tests/eosjs-serialize.test.ts +++ b/src/tests/eosjs-serialize.test.ts @@ -114,13 +114,6 @@ describe('Serialize', () => { expect(serialBuffer.getName()).toEqual(expectedName); }); - it('should not be able to push name with an account name too short', () => { - const name = ''; - - const shouldFail = () => serialBuffer.pushName(name); - expect(shouldFail).toThrowError(invalidNameErrorMessage); - }); - it('should not be able to push name with an account name too long', () => { const name = 'abcdabcdabcdab'; From 112218af10cbe2f9f5d9bd675b9888e5af47a6ea Mon Sep 17 00:00:00 2001 From: "Block.one DevOps" Date: Fri, 9 Apr 2021 21:11:20 +0000 Subject: [PATCH 2/2] Updating package.json and yarn.lock --- package.json | 2 +- yarn.lock | 42 +++++++++++++++++++++--------------------- 2 files changed, 22 insertions(+), 22 deletions(-) diff --git a/package.json b/package.json index 6b23408b3..983ca77e4 100644 --- a/package.json +++ b/package.json @@ -47,7 +47,7 @@ "ts-jest": "^26.5.4", "ts-loader": "^8.1.0", "typescript": "^4.2.4", - "webpack": "^5.31.0", + "webpack": "^5.31.2", "webpack-cli": "^4.6.0" }, "jest": { diff --git a/yarn.lock b/yarn.lock index 34f5a309d..0e08be7ea 100644 --- a/yarn.lock +++ b/yarn.lock @@ -2167,9 +2167,9 @@ ecurve@1.0.5: bigi "^1.1.0" electron-to-chromium@^1.3.649: - version "1.3.710" - resolved "https://registry.yarnpkg.com/electron-to-chromium/-/electron-to-chromium-1.3.710.tgz#b33d316e5d6de92b916e766d8a478d19796ffe11" - integrity sha512-b3r0E2o4yc7mNmBeJviejF1rEx49PUBi+2NPa7jHEX3arkAXnVgLhR0YmV8oi6/Qf3HH2a8xzQmCjHNH0IpXWQ== + version "1.3.711" + resolved "https://registry.yarnpkg.com/electron-to-chromium/-/electron-to-chromium-1.3.711.tgz#92c3caf7ffed5e18bf63f66b4b57b4db2409c450" + integrity sha512-XbklBVCDiUeho0PZQCjC25Ha6uBwqqJeyDhPLwLwfWRAo4x+FZFsmu1pPPkXT+B4MQMQoQULfyaMltDopfeiHQ== elegant-spinner@^1.0.1: version "1.0.1" @@ -2867,9 +2867,9 @@ globals@^12.1.0: type-fest "^0.8.1" globals@^13.6.0: - version "13.7.0" - resolved "https://registry.yarnpkg.com/globals/-/globals-13.7.0.tgz#aed3bcefd80ad3ec0f0be2cf0c895110c0591795" - integrity sha512-Aipsz6ZKRxa/xQkZhNg0qIWXT6x6rD46f6x/PCnBomlttdIyAPak4YD9jTmKpZ72uROSMU87qJtcgpgHaVchiA== + version "13.8.0" + resolved "https://registry.yarnpkg.com/globals/-/globals-13.8.0.tgz#3e20f504810ce87a8d72e55aecf8435b50f4c1b3" + integrity sha512-rHtdA6+PDBIjeEvA91rpqzEvk/k3/i7EeNQiryiWuJH0Hw9cpyJMAt2jtbAwUaRdhD+573X4vWw6IcjKPasi9Q== dependencies: type-fest "^0.20.2" @@ -3186,9 +3186,9 @@ is-descriptor@^1.0.0, is-descriptor@^1.0.2: kind-of "^6.0.2" is-docker@^2.0.0: - version "2.2.0" - resolved "https://registry.yarnpkg.com/is-docker/-/is-docker-2.2.0.tgz#b037c8815281edaad6c2562648a5f5f18839d5f7" - integrity sha512-K4GwB4i/HzhAzwP/XSlspzRdFTI9N8OxJOyOU7Y5Rz+p+WBokXWVWblaJeBkggthmoSV0OoGTH5thJNvplpkvQ== + version "2.2.1" + resolved "https://registry.yarnpkg.com/is-docker/-/is-docker-2.2.1.tgz#33eeabe23cfe86f14bde4408a02c0cfb853acdaa" + integrity sha512-F+i2BKsFrH66iaUFc0woD8sLy8getkwTwtOBjvs56Cx4CgJDeKQeqfz8wAYiSb8JOprWhHH5p77PbmYCvvUuXQ== is-extendable@^0.1.0, is-extendable@^0.1.1: version "0.1.1" @@ -4161,12 +4161,12 @@ micromatch@^3.1.4: to-regex "^3.0.2" micromatch@^4.0.0, micromatch@^4.0.2: - version "4.0.2" - resolved "https://registry.yarnpkg.com/micromatch/-/micromatch-4.0.2.tgz#4fcb0999bf9fbc2fcbdd212f6d629b9a56c39259" - integrity sha512-y7FpHSbMUMoyPbYUSzO6PaZ6FyRnQOpHuKwbo1G+Knck95XVU4QAiKdGEnj5wwoS7PlOgthX/09u5iFJ+aYf5Q== + version "4.0.3" + resolved "https://registry.yarnpkg.com/micromatch/-/micromatch-4.0.3.tgz#fdad8352bf0cbeb89b391b5d244bc22ff3dd4ec8" + integrity sha512-ueuSaP4i67F/FAUac9zzZ0Dz/5KeKDkITYIS/k4fps+9qeh1SkeH6gbljcqz97mNBOsaWZ+iv2UobMKK/yD+aw== dependencies: braces "^3.0.1" - picomatch "^2.0.5" + picomatch "^2.2.1" miller-rabin@^4.0.0: version "4.0.1" @@ -4568,9 +4568,9 @@ path-type@^4.0.0: integrity sha512-gDKb8aZMDeD/tZWs9P6+q0J9Mwkdl6xMV8TjnGP3qJVJ06bdMgkbBlLU8IdfOsIsFz2BW1rNVT3XuNEl8zPAvw== pbkdf2@^3.0.3: - version "3.1.1" - resolved "https://registry.yarnpkg.com/pbkdf2/-/pbkdf2-3.1.1.tgz#cb8724b0fada984596856d1a6ebafd3584654b94" - integrity sha512-4Ejy1OPxi9f2tt1rRV7Go7zmfDQ+ZectEQz3VGUQhgq62HtIRPDyG/JtnwIxs6x3uNMwo2V7q1fMvKjb+Tnpqg== + version "3.1.2" + resolved "https://registry.yarnpkg.com/pbkdf2/-/pbkdf2-3.1.2.tgz#dd822aa0887580e52f1a039dc3eda108efae3075" + integrity sha512-iuh7L6jA7JEGu2WxDwtQP1ddOpaJNC4KlDEFfdQajSGgGPNi4OyDc2R7QnbY2bR9QjBVGwgvTdNJZoE7RaxUMA== dependencies: create-hash "^1.1.2" create-hmac "^1.1.4" @@ -4588,7 +4588,7 @@ performance-now@^2.1.0: resolved "https://registry.yarnpkg.com/performance-now/-/performance-now-2.1.0.tgz#6309f4e0e5fa913ec1c69307ae364b4b377c9e7b" integrity sha1-Ywn04OX6kT7BxpMHrjZLSzd8nns= -picomatch@^2.0.4, picomatch@^2.0.5, picomatch@^2.2.1: +picomatch@^2.0.4, picomatch@^2.2.1: version "2.2.2" resolved "https://registry.yarnpkg.com/picomatch/-/picomatch-2.2.2.tgz#21f333e9b6b8eaff02468f5146ea406d345f4dad" integrity sha512-q0M/9eZHzmr0AulXyPwNfZjtwZ/RBZlbN3K3CErVrk50T2ASYI7Bye0EvekFY3IP1Nt2DHu0re+V2ZHIpMkuWg== @@ -5874,10 +5874,10 @@ webpack-sources@^2.1.1: source-list-map "^2.0.1" source-map "^0.6.1" -webpack@^5.31.0: - version "5.31.0" - resolved "https://registry.yarnpkg.com/webpack/-/webpack-5.31.0.tgz#fab61d0be896feca4af87bdad5c18815c0d63455" - integrity sha512-3fUfZT/FUuThWSSyL32Fsh7weUUfYP/Fjc/cGSbla5KiSo0GtI1JMssCRUopJTvmLjrw05R2q7rlLtiKdSzkzQ== +webpack@^5.31.2: + version "5.31.2" + resolved "https://registry.yarnpkg.com/webpack/-/webpack-5.31.2.tgz#40d9b9d15b7d76af73d3f1cae895b82613a544d6" + integrity sha512-0bCQe4ybo7T5Z0SC5axnIAH+1WuIdV4FwLYkaAlLtvfBhIx8bPS48WHTfiRZS1VM+pSiYt7e/rgLs3gLrH82lQ== dependencies: "@types/eslint-scope" "^3.7.0" "@types/estree" "^0.0.46"