Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty prefix #250

Merged
merged 3 commits into from
Sep 24, 2024
Merged

Fix empty prefix #250

merged 3 commits into from
Sep 24, 2024

Conversation

jesper-friis
Copy link
Contributor

Description

Corrected handling of empty prefixes in Triplestore.expand_iri() and Triplestore.prefix_iri().
Added corresponding tests.

Type of change

  • Bug fix and code cleanup
  • New feature
  • Documentation update
  • Testing

Checklist for the reviewer

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?
  • Is the code properly tested?

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.66%. Comparing base (d8ba502) to head (309b2e5).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #250      +/-   ##
==========================================
+ Coverage   78.40%   78.66%   +0.25%     
==========================================
  Files          18       18              
  Lines        1723     1725       +2     
==========================================
+ Hits         1351     1357       +6     
+ Misses        372      368       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From reading the docstrings of prefix_iri and base_iri, it is not clear to me how these two functions are supposed to work. This needs to be explained better, perhaps adding a few examples is possible. As it is now, I do not clear when and why an error is raised.

@jesper-friis
Copy link
Contributor Author

From reading the docstrings of prefix_iri and base_iri, it is not clear to me how these two functions are supposed to work. This needs to be explained better, perhaps adding a few examples is possible. As it is now, I do not clear when and why an error is raised.

Added examples to the docstrings of the expand_iri() and prefix_iri() methods.

@jesper-friis jesper-friis merged commit 53efcf6 into master Sep 24, 2024
19 checks passed
@jesper-friis jesper-friis deleted the fix-empty-prefix branch September 24, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants